Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Components): add replace option #15658

Closed
wants to merge 1 commit into from
Closed

docs(guide/Components): add replace option #15658

wants to merge 1 commit into from

Conversation

pmcelhaney
Copy link
Contributor

@pmcelhaney pmcelhaney commented Jan 31, 2017 •
edited
Loading

Adds "replace" in the comparison to directives. The replace option is deprecated, but it still exists in directives, so it's worth pointing out as a difference between directives and components.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Docs

What is the current behavior? (You can also link to an open issue here)

n/a

What is the new behavior (if this is a feature change)?

n/a

Does this PR introduce a breaking change?

No

Please check if the PR fulfills these requirements

Other information:

I wanted to link to this question on Stack Overflow, but I'm not sure whether to use Markdown or some other syntax. https://stackoverflow.com/questions/24194972/why-is-replace-deprecated-in-angularjs

docs(guide/Components): add replace option
2eba0a2 
Add "replace" in the table comparing components to directives. The replace option is deprecated, but it still exists in directives, so it's worth pointing out as a difference between directives and components.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gkalpak
Copy link
Member

gkalpak commented Jan 31, 2017

This was a deliberate omission (to discourage people from using replace: true even on directives). But maybe it is more confusing to omit it altogether and may lead people making incorrect assumptions. Since we haven't removed it from the $compile docs or other places, I think adding it here clears things up.

Can you sign the CLA?

@pmcelhaney
Copy link
Contributor Author

Thanks, I signed the SLA.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@gkalpak gkalpak closed this in d03357a Jan 31, 2017
gkalpak pushed a commit that referenced this pull request Jan 31, 2017
@gkalpak
docs(guide/component): add replace option
19ea708 
Add `replace` to the table comparing components to directives options. The
`replace` option is deprecated, but it is still documented for directives, so
it is worth pointing it out as a difference between directives and components.

Closes #15658
ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017
@ellimist
docs(guide/component): add replace option
c8cfa0f 
Add `replace` to the table comparing components to directives options. The
`replace` option is deprecated, but it is still documented for directives, so
it is worth pointing it out as a difference between directives and components.

Closes angular#15658
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmcelhaney @googlebot @gkalpak